* Optimized statement with REGEX by using `case`
REGEX is a great feature of BASH, but in this case it was energy
needlessly spent. A `case` statement suffices. Bring in REGEX when
you're going to make good use of it, otherwise it's just going to bog
down your code.
I also wanted to strip the ` || exit 1` on the last line, but I wasn't
sure if this file is meant to be sourced or not; if not, then exiting
like that is redundant because it will already exit with whichever
status the last command provides, unless `popd` specifically offers
unhelpful or no exit statuses.
* Optimize as before but with 2nd REGEX instance
This time is much like the last commit, so I won't repeat, but I will
say that you're using a double- or even triple-negative, which
obfuscates your goal. Where you were doing...
[ ! -n VAR ] &&
You were basically saying this convolution:
If it's true that it's not true that VAR is not empty.
Very confusing. Instead, I've opted for:
If it's true that Var is empty.
Makes immediate sense and is easier to parse, visually speaking.
The tests are failing because $1 is being passed through from the
initial loading. When this loads in the shell, $1 is empty though so
the code works-for-me, but just not the tests.
This filters the $1 input to ensure its one of the valid types
expected inside the ./enabled directory.
Terminal for Life
Noah Gorny
Travis Swicegood