Commit Graph

16 Commits

Author SHA1 Message Date
John D Pell
1c3cbf7ca6 Delete .shellcheckrc (#1947)
* CI: disable Ubuntu 16.04 as it's EOL

https://github.blog/changelog/2021-04-29-github-actions-ubuntu-16-04-lts-virtual-environment-will-be-removed-on-september-20-2021/

* main: lint false positive

* install: lint

* plugins/cmd-returned-notify: don't `export`

* plugins/xterm: lint

* plugins/git: lint

* plugins/goenv: lint

* plugins/alias-completion: lint false positives

* plugins/alias-completion: fix SC2155, SC2154

Declare `locals` at the top of the function

* completion: lint completions using `bash_completion` functions

Match the style of the existing code

* completion/knife: lint false positives

* completion/knife: lint

* completion/sdkman: lint

* completion/composer: lint

* Move `.shellcheckrc` under `themes/`

* lib/theme: fix SC2155, SC2154, SC2034

* lib/colors: don't warn on unused variables

We assign a large number of variables here and they may or may not be used anywhere else, so disable SC2034 for this file (only).

Alsö disable SC2005 as the functions in this file were written before `printf` was invented and have to do some fancy metascripting to get escape sequences interpreted reliably. I’m not smart enough to fix this to use `printf`, so leave it for now.

* themes/agnoster: lint

* themes: disable SC2154 for colors

Each one of these themes will need it’s own fix for SC2154, possibly upstream.

Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.

* themes: disable SC2154, fix SC2155

Each one of these themes will need it’s own fix for SC2154, possibly upstream.

Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.

* Delete `.shellcheckrc`

* remove executable bit
2021-09-18 12:50:59 +03:00
Noah Gorny
c6f6d8c27a plugins: Fix shellcheck warnings on already linted files 2021-09-09 20:57:03 +03:00
Noah Gorny
2120be9372 plugins: Fix alias-completion by using helper util
By using _bash-it-array-contains-element, we can safetly iterate over
elements in the $completions array
2021-05-15 11:42:10 +03:00
Noah Gorny
1b7448bc9d plugins: alias-completion: Revert back to read without -r 2021-04-22 20:38:30 +03:00
John Fred Fadrigalan
7b8dbd39bc Clean alias completion plugin (#1872)
* Sort plugins/available

* Clean alias-completion plugin

* Fix shellcheck warning. SC1090

* Change shellcheck source to /dev/null for explicity

* Disable shellcheck warning SC2162
2021-04-22 01:46:50 +03:00
Noah Gorny
1c05d71819 alias-completion: Use 'command rm' instead of rm to avoid aliases 2020-12-14 01:25:58 +02:00
Noah Gorny
a224d65f5b plugins: Fix quotes around prec_word agruments 2020-06-24 15:11:49 +03:00
Taro Sato
a7a777b20a Pass all the expected arguments to completion function 2020-02-28 01:04:19 -08:00
Taro Sato
fbc8f7ddf4 Add comment explaining compl_func_args 2020-02-23 18:40:54 -08:00
Taro Sato
fe26adf7ac Pass the aliased command as an argument to _filedir_xspec 2020-02-22 16:20:40 -08:00
Piotr Rogoża
f8fd94d46f Fixed opening vim 2018-04-02 01:55:36 +02:00
Julio Borja Barra
137b700097 Change template for temp file creation
This makes the script compatible with other 'versions' of `mktemp`.
2018-03-07 12:54:01 +01:00
Jean Jordaan
ca6a1ae2db Use 'mktemp -t', leave tempfile cleanup to the OS 2017-09-28 21:54:58 +07:00
Nils Winkler
9ebbf6e6e5 Updated some load priorities
These will not work yet, since they are used across component types, but this will start working once everything is loaded from the same "enabled" directory.
2017-06-24 17:31:30 +02:00
Eduardo Bellido Bellido
d20bcf5882 Closes issue 809 2016-10-26 21:27:52 +02:00
Nils Winkler
36caf70f8d Renamed alias-completion file to match naming conventions 2015-10-15 11:28:58 +02:00