* install.sh
- Added a Choice to add existing .bash_profile to bash-it version.
- Also it is possible to only 'enter' the installaion process.
- Improved yes/no query for funtion load_some()
* Use curl to retrieve the raw install script from github
* Execute payload directly with bash -c without requiring file write
* Detect bash execution (as apposed to terminal or script file execution) and assume that this is a direct install
* On direct install
* * purge ~/.bash_it if present
* * git clone repo to ~/.bash_it
* * continue installation as normal
We get an error from cp
We still respond that we made a backup
Instead if .bas_profile exists and cp is a success then prompt informing the user that we made a backup
or inform them that no .bash_profile was found so no need to make a back up at this point.
It's nice that we make a backup but…
* what if a back-up already exists?
* what if this is the 2nd, 3rd or 4th time I'm executing the script?
We backup to .bash_profile.bak or .bash_plofile.bak.{count} if .bash_plofile.bak already exists.
iow
.bash_plofile.bak if not exist
.bash_plofile.bak.1 if exists
.bash_plofile.bak.2 if 2 exists
.bash_plofile.bak.3 if 3 exists etc…
Newest backup with the highest number.
At least a general conformance to the same style if nothing else
Based on what appeared to be the most used or most sensible conventions which lead to the following
Braces around variables
Preserve quotes and quote paths
statements begin on the same line
No trailing white space
Respect 120 chars page width at least
Use brackets instead of back-ticks
Two space indent 4 space continuation
No logic was harmed in the making of this commit.
* CI: disable Ubuntu 16.04 as it's EOL
https://github.blog/changelog/2021-04-29-github-actions-ubuntu-16-04-lts-virtual-environment-will-be-removed-on-september-20-2021/
* main: lint false positive
* install: lint
* plugins/cmd-returned-notify: don't `export`
* plugins/xterm: lint
* plugins/git: lint
* plugins/goenv: lint
* plugins/alias-completion: lint false positives
* plugins/alias-completion: fix SC2155, SC2154
Declare `locals` at the top of the function
* completion: lint completions using `bash_completion` functions
Match the style of the existing code
* completion/knife: lint false positives
* completion/knife: lint
* completion/sdkman: lint
* completion/composer: lint
* Move `.shellcheckrc` under `themes/`
* lib/theme: fix SC2155, SC2154, SC2034
* lib/colors: don't warn on unused variables
We assign a large number of variables here and they may or may not be used anywhere else, so disable SC2034 for this file (only).
Alsö disable SC2005 as the functions in this file were written before `printf` was invented and have to do some fancy metascripting to get escape sequences interpreted reliably. I’m not smart enough to fix this to use `printf`, so leave it for now.
* themes/agnoster: lint
* themes: disable SC2154 for colors
Each one of these themes will need it’s own fix for SC2154, possibly upstream.
Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.
* themes: disable SC2154, fix SC2155
Each one of these themes will need it’s own fix for SC2154, possibly upstream.
Due to the way themes are, it's entirely normal to have a *lot* of false positives for SC2034. So much so, that I have to admit that it is probably just not worth linting for SC2034 despite my dislike of blanket ignore rules.
* Delete `.shellcheckrc`
* remove executable bit
Convert `var=${dirname $filename)` to `var="${filename%/*}` in cases where there is no ambiguity.
Make sure that the path in `$BASH_IT` is absolute because this path gets embedded in the template `.bash_profile` file if selected by the user.
This will ensure users will specify whether they want to overwrite the
backup or not, and check it even when we do silent installation
This does change the default behaviour and exits if the -f flag is not
specified and a backup is present.
Silence errors when installing
```
Would you like to enable the ag aliases? [y/N] y
~/.bash_it/lib/helpers.bash: line 488: _bash-it-clean-component-cache: command not found
ag enabled with priority 150.
```
NOTE: This doesn't make Bash-it usable as there's so many similar errors scattered in other locations, this commit simply makes installer works
Signed-off-by: 林博仁 <Buo.Ren.Lin@gmail.com>
In addition to the regular /etc/bash_completion, the one from Homebrew
is loaded when running on OS X, and when Homebrew is installed.
Also added the system completion to the default install options, since
this is a feature that's requested frequently.
sebokopter
nickl-
Noah Gorny
John D Pell
John D Pell
buhl
egvimo
Kyle Welsby
polytomous
Nils Winkler
林博仁
Shingo Kitagawa
ravenhall
Daniele Andreoli
Justin Dray