From ca6a1ae2dbc344b920d0aeb403704c37e1d603be Mon Sep 17 00:00:00 2001 From: Jean Jordaan Date: Thu, 28 Sep 2017 21:54:58 +0700 Subject: [PATCH] Use 'mktemp -t', leave tempfile cleanup to the OS --- lib/composure.bash | 4 ++-- lib/helpers.bash | 4 ++-- plugins/available/alias-completion.plugin.bash | 3 +-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/composure.bash b/lib/composure.bash index 70d9027c..5ef7104c 100644 --- a/lib/composure.bash +++ b/lib/composure.bash @@ -196,7 +196,7 @@ draft () cmd=$(eval "history | grep '^[[:blank:]]*$num' | head -1" | sed 's/^[[:blank:][:digit:]]*//') fi eval "$func() { $cmd; }" - typeset file=$(mktemp /tmp/draft.XXXX) + typeset file=$(mktemp -t draft.XXXX) typeset -f $func > $file transcribe $func $file draft rm $file 2>/dev/null @@ -300,7 +300,7 @@ revise () group composure typeset func=$1 - typeset temp=$(mktemp /tmp/revise.XXXX) + typeset temp=$(mktemp -t revise.XXXX) if [ -z "$func" ]; then printf '%s\n' 'missing parameter(s)' diff --git a/lib/helpers.bash b/lib/helpers.bash index 0405eede..902e6a2b 100644 --- a/lib/helpers.bash +++ b/lib/helpers.bash @@ -500,7 +500,7 @@ _help-plugins() # display a brief progress message... printf '%s' 'please wait, building help...' - typeset grouplist=$(mktemp /tmp/grouplist.XXXXXX) + typeset grouplist=$(mktemp -t grouplist.XXXXXX) typeset func for func in $(typeset_functions) do @@ -547,7 +547,7 @@ all_groups () group 'lib' typeset func - typeset file=$(mktemp /tmp/composure.XXXX) + typeset file=$(mktemp -t composure.XXXX) for func in $(typeset_functions) do typeset -f $func | metafor group >> $file diff --git a/plugins/available/alias-completion.plugin.bash b/plugins/available/alias-completion.plugin.bash index 368d9f47..b14131b4 100644 --- a/plugins/available/alias-completion.plugin.bash +++ b/plugins/available/alias-completion.plugin.bash @@ -29,8 +29,7 @@ function alias_completion { (( ${#completions[@]} == 0 )) && return 0 # create temporary file for wrapper functions and completions - rm -f "/tmp/${namespace}-*.tmp" # preliminary cleanup - local tmp_file; tmp_file="$(mktemp "/tmp/${namespace}-${RANDOM}XXX.tmp")" || return 1 + local tmp_file; tmp_file="$(mktemp -t "${namespace}-${RANDOM}XXX.tmp")" || return 1 local completion_loader; completion_loader="$(complete -p -D 2>/dev/null | sed -Ene 's/.* -F ([^ ]*).*/\1/p')"