From cb44790e61dbdb62b0fabe50e65edd5447a4c62c Mon Sep 17 00:00:00 2001
From: Ira Abramov <github@ira.abramov.org>
Date: Mon, 17 Apr 2023 16:48:59 +0300
Subject: [PATCH 1/2] Add a --help option

---
 plugins/available/gif.plugin.bash | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/plugins/available/gif.plugin.bash b/plugins/available/gif.plugin.bash
index a04ff5c7..21dcc139 100644
--- a/plugins/available/gif.plugin.bash
+++ b/plugins/available/gif.plugin.bash
@@ -64,7 +64,7 @@ function v2gif() {
 	fi
 
 	# Parse the options
-	args=$("$getopt" -l "alert:" -l "lossy:" -l "width:" -l del,delete -l high -l tag -l "fps:" -l webm -o "a:l:w:f:dhmt" -- "$@") || {
+	args=$("$getopt" -l "alert:" -l "lossy:" -l "width:" -l del,delete -l high -l help -l tag -l "fps:" -l webm -o "a:l:w:f:dhmt" -- "$@") || {
 		echo 'Terminating...' >&2
 		return 2
 	}
@@ -82,6 +82,7 @@ function v2gif() {
 	local fps=""
 	local make_webm=""
 	local alert=5000
+	local printhelp=""
 	while [[ $# -ge 1 ]]; do
 		case "$1" in
 			--)
@@ -94,6 +95,11 @@ function v2gif() {
 				opt_del_after="true"
 				shift
 				;;
+			--help)
+				# Print Help
+				printhelp="true"
+				shift
+				;;
 			-h | --high)
 				#High Quality, use gifski
 				gifski="$(type -p gifski)"
@@ -141,7 +147,7 @@ function v2gif() {
 		esac
 	done
 
-	if [[ -z "$*" ]]; then
+	if [[ -z "$*" || "$printhelp" ]]; then
 		echo "$(tput setaf 1)No input files given. Example: v2gif file [file...] [-w <max width (pixels)>] [-l <lossy level>] $(tput sgr 0)"
 		echo "-d/--del/--delete Delete original vid if done suceessfully (and file not over the size limit)"
 		echo "-h/--high         High Quality - use Gifski instead of gifsicle"

From 33342129449b549a0087c5e795d6dc271dd2ead8 Mon Sep 17 00:00:00 2001
From: Ira Abramov <github@ira.abramov.org>
Date: Mon, 17 Apr 2023 20:05:48 +0300
Subject: [PATCH 2/2] Fix commandline options for the current versions of
 gifski and gifsicle

---
 plugins/available/gif.plugin.bash | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/plugins/available/gif.plugin.bash b/plugins/available/gif.plugin.bash
index 21dcc139..7cca37d4 100644
--- a/plugins/available/gif.plugin.bash
+++ b/plugins/available/gif.plugin.bash
@@ -72,9 +72,9 @@ function v2gif() {
 	eval set -- "$args"
 	local use_gifski=""
 	local opt_del_after=""
-	local maxsize=""
-	local lossiness=""
-	local maxwidthski=""
+	local maxsize=()
+	local lossiness=()
+	local maxwidthski=()
 	local giftagopt=""
 	local giftag=""
 	local defaultfps=10
@@ -112,8 +112,8 @@ function v2gif() {
 				shift
 				;;
 			-w | --width)
-				maxsize="-vf scale=$2:-1"
-				maxwidthski="-W $2"
+				maxsize=(-vf "scale=$2:-1")
+				maxwidthski=(-W "$2")
 				giftag="${giftag}-w$2"
 				shift 2
 				;;
@@ -124,7 +124,7 @@ function v2gif() {
 				;;
 			-l | --lossy)
 				# Use giflossy parameter
-				lossiness="--lossy=$2"
+				lossiness=("--lossy=$2")
 				giftag="${giftag}-l$2"
 				shift 2
 				;;
@@ -170,7 +170,7 @@ function v2gif() {
 		local del_after=$opt_del_after
 
 		if [[ -n "$make_webm" ]]; then
-			$ffmpeg -loglevel panic -i "$file" \
+			$ffmpeg -loglevel warning -i "$file" \
 				-c:v libvpx -crf 4 -threads 0 -an -b:v 2M -auto-alt-ref 0 \
 				-quality best -loop 0 "${file%.*}.webm" || return 2
 		fi
@@ -190,12 +190,12 @@ function v2gif() {
 
 		if [[ "$use_gifski" = "true" ]]; then
 			# I trust @pornel to do his own resizing optimization choices
-			$ffmpeg -loglevel panic -i "$file" -r "$fps" -vcodec png v2gif-tmp-%05d.png \
-				&& $gifski v2gif-tmp-*.png "$maxwidthski" --fps "$(printf "%.0f" "$fps")" -o "$output_file" || return 2
+			$ffmpeg -loglevel warning -i "$file" -r "$fps" -vcodec png v2gif-tmp-%05d.png \
+				&& $gifski "${maxwidthski[@]}" --fps "$(printf "%.0f" "$fps")" -o "$output_file" v2gif-tmp-*.png || return 2
 		else
-			$ffmpeg -loglevel panic -i "$file" "$maxsize" -r "$fps" -vcodec png v2gif-tmp-%05d.png \
+			$ffmpeg -loglevel warning -i "$file" "${maxsize[@]}" -r "$fps" -vcodec png v2gif-tmp-%05d.png \
 				&& $convert +dither -layers Optimize v2gif-tmp-*.png GIF:- \
-				| $gifsicle "$lossiness" --no-warnings --colors 256 --delay="$(echo "100/$fps" | bc)" --loop --optimize=3 --multifile - > "$output_file" || return 2
+				| $gifsicle "${lossiness[@]}" --no-warnings --colors 256 --delay="$(echo "100/$fps" | bc)" --loop --optimize=3 --multifile - > "$output_file" || return 2
 		fi
 
 		rm v2gif-tmp-*.png
@@ -305,7 +305,7 @@ function any2webm() {
 
 		echo "$(tput setaf 2)Creating '$output_file' ...$(tput sgr 0)"
 
-		$ffmpeg -loglevel panic -i "$file" \
+		$ffmpeg -loglevel warning -i "$file" \
 			-c:v libvpx -crf 4 -threads 0 -an -b:v "$bandwidth" -auto-alt-ref 0 \
 			-quality best "$fps" "$size" -loop 0 -pix_fmt yuva420p "$output_file" || return 2