From 99decb80108083040470a55c235dd9c6e7acaed8 Mon Sep 17 00:00:00 2001
From: John D Pell <John+Git@gaelicWizard.net>
Date: Thu, 3 Feb 2022 21:48:03 -0800
Subject: [PATCH] test/bash_it: `shellcheck`

---
 test/bash_it/bash_it.bats | 256 ++++++++++++++++----------------------
 1 file changed, 110 insertions(+), 146 deletions(-)

diff --git a/test/bash_it/bash_it.bats b/test/bash_it/bash_it.bats
index ef3cdbab..dc9d2811 100644
--- a/test/bash_it/bash_it.bats
+++ b/test/bash_it/bash_it.bats
@@ -9,27 +9,24 @@ function local_setup_file() {
 }
 
 @test "bash-it: verify that the test fixture is available" {
-  assert_file_exist "$BASH_IT/aliases/available/a.aliases.bash"
-  assert_file_exist "$BASH_IT/aliases/available/b.aliases.bash"
+  assert_file_exist "${BASH_IT?}/aliases/available/a.aliases.bash"
+  assert_file_exist "${BASH_IT?}/aliases/available/b.aliases.bash"
 }
 
 @test "bash-it: load aliases in order" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/150---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/aliases/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -37,22 +34,19 @@ function local_setup_file() {
 }
 
 @test "bash-it: load aliases in priority order" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/175---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/175---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/aliases/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/175---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/175---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -60,24 +54,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load aliases and plugins in priority order" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/150---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/aliases/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---b.aliases.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/plugins/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -85,25 +76,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load aliases, plugins and completions in priority order" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
-  mkdir -p $BASH_IT/completion/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/150---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/completion/enabled/350---b.completion.bash
-  assert_link_exist "$BASH_IT/completion/enabled/350---b.completion.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/plugins/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/completion/enabled/350---b.completion.bash"
+  assert_link_exist "${BASH_IT?}/completion/enabled/350---b.completion.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -112,25 +99,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load aliases, plugins and completions in priority order, even if the priority says otherwise" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
-  mkdir -p $BASH_IT/completion/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/450---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/450---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/completion/enabled/350---b.completion.bash
-  assert_link_exist "$BASH_IT/completion/enabled/350---b.completion.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/plugins/enabled/950---c.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/950---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/450---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/450---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/completion/enabled/350---b.completion.bash"
+  assert_link_exist "${BASH_IT?}/completion/enabled/350---b.completion.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/plugins/enabled/950---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/950---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -139,24 +122,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load aliases and plugins in priority order, with one alias higher than plugins" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/aliases/enabled/350---a.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/350---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/aliases/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---b.aliases.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/plugins/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/aliases/enabled/350---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/350---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -166,21 +146,19 @@ function local_setup_file() {
 }
 
 @test "bash-it: load global aliases in order" {
-  mkdir -p $BASH_IT/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/enabled/150---a.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/enabled/150---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---b.aliases.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -188,21 +166,19 @@ function local_setup_file() {
 }
 
 @test "bash-it: load global aliases in priority order" {
-  mkdir -p $BASH_IT/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/enabled/175---a.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/175---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/enabled/175---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/175---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---b.aliases.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -210,23 +186,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load global aliases and plugins in priority order" {
-  mkdir -p $BASH_IT/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/enabled/150---a.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---b.aliases.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/enabled/150---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -234,23 +208,21 @@ function local_setup_file() {
 }
 
 @test "bash-it: load global aliases and plugins in priority order, with one alias higher than plugins" {
-  mkdir -p $BASH_IT/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/enabled/350---a.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/350---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---b.aliases.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/enabled/350---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/350---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---c.plugin.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -260,27 +232,24 @@ function local_setup_file() {
 }
 
 @test "bash-it: load global aliases and plugins in priority order, individual old directories are loaded later" {
-  mkdir -p $BASH_IT/enabled
-  mkdir -p $BASH_IT/aliases/enabled
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
-
-  ln -s $BASH_IT/aliases/available/a.aliases.bash $BASH_IT/enabled/350---a.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/350---a.aliases.bash"
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---b.aliases.bash"
-  ln -s $BASH_IT/plugins/available/c.plugin.bash $BASH_IT/enabled/250---c.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---c.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/a.aliases.bash" "${BASH_IT?}/enabled/350---a.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/350---a.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/c.plugin.bash" "${BASH_IT?}/enabled/250---c.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---c.plugin.bash"
   # Add one file in the old directory structure
-  ln -s $BASH_IT/aliases/available/b.aliases.bash $BASH_IT/aliases/enabled/150---b.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---b.aliases.bash"
+  ln -s "${BASH_IT?}/aliases/available/b.aliases.bash" "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---b.aliases.bash"
 
   # The `test_alias` alias should not exist
   run alias test_alias &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias test_alias &> /dev/null
   assert_success
@@ -290,53 +259,48 @@ function local_setup_file() {
 }
 
 @test "bash-it: load enabled aliases from new structure, priority-based" {
-  mkdir -p $BASH_IT/enabled
-  ln -s $BASH_IT/aliases/available/atom.aliases.bash $BASH_IT/enabled/150---atom.aliases.bash
-  assert_link_exist "$BASH_IT/enabled/150---atom.aliases.bash"
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/enabled/250---base.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/atom.aliases.bash" "${BASH_IT?}/enabled/150---atom.aliases.bash"
+  assert_link_exist "${BASH_IT?}/enabled/150---atom.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/enabled/250---base.plugin.bash"
 
   # The `ah` alias should not exist
   run alias ah &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias ah &> /dev/null
   assert_success
 }
 
 @test "bash-it: load enabled aliases from old structure, priority-based" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
-  ln -s $BASH_IT/aliases/available/atom.aliases.bash $BASH_IT/aliases/enabled/150---atom.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/150---atom.aliases.bash"
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/250---base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/250---base.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/atom.aliases.bash" "${BASH_IT?}/aliases/enabled/150---atom.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/150---atom.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/250---base.plugin.bash"
 
   # The `ah` alias should not exist
   run alias ah &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias ah &> /dev/null
   assert_success
 }
 
 @test "bash-it: load enabled aliases from old structure, without priorities" {
-  mkdir -p $BASH_IT/aliases/enabled
-  mkdir -p $BASH_IT/plugins/enabled
-  ln -s $BASH_IT/aliases/available/atom.aliases.bash $BASH_IT/aliases/enabled/atom.aliases.bash
-  assert_link_exist "$BASH_IT/aliases/enabled/atom.aliases.bash"
-  ln -s $BASH_IT/plugins/available/base.plugin.bash $BASH_IT/plugins/enabled/base.plugin.bash
-  assert_link_exist "$BASH_IT/plugins/enabled/base.plugin.bash"
+  ln -s "${BASH_IT?}/aliases/available/atom.aliases.bash" "${BASH_IT?}/aliases/enabled/atom.aliases.bash"
+  assert_link_exist "${BASH_IT?}/aliases/enabled/atom.aliases.bash"
+  ln -s "${BASH_IT?}/plugins/available/base.plugin.bash" "${BASH_IT?}/plugins/enabled/base.plugin.bash"
+  assert_link_exist "${BASH_IT?}/plugins/enabled/base.plugin.bash"
 
   # The `ah` alias should not exist
   run alias ah &> /dev/null
   assert_failure
 
-  load "$BASH_IT/bash_it.sh"
+  load "${BASH_IT?}/bash_it.sh"
 
   run alias ah &> /dev/null
   assert_success