Merge pull request #1790 from BarbUk/clean/theme_starting_by_b

Clean b* themes

clean_files.txt

@@ -39,6 +39,13 @@ themes/barbuk
 themes/atomic
 themes/axin
 themes/base.theme.bash
+themes/bakke
+themes/binaryanomaly
+themes/bira
+themes/bobby
+themes/bobby-python
+themes/brainy
+themes/brunton
 
 # plugins
 #

themes/atomic/atomic.theme.bash

@@ -225,17 +225,15 @@ _atomic_completion() {
 	actions="show hide"
 	segments="battery clock exitcode python ruby scm sudo todo"
 	case "${_action}" in
-		show)
+		show | hide)
-			read -r -a COMPREPLY <<< "$(compgen -W "${segments}" -- "${cur}")"
+			# shellcheck disable=SC2207
-			return 0
+			COMPREPLY=($(compgen -W "${segments}" -- "${cur}"))
-			;;
-		hide)
-			read -r -a COMPREPLY <<< "$(compgen -W "${segments}" -- "${cur}")"
 			return 0
 			;;
 	esac
 
-	read -r -a COMPREPLY <<< "$(compgen -W "${actions}" -- "${cur}")"
+	# shellcheck disable=SC2207
+	COMPREPLY=($(compgen -W "${actions}" -- "${cur}"))
 	return 0
 }
 

themes/bakke/bakke.theme.bash

@@ -1,4 +1,5 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
+
 SCM_THEME_PROMPT_DIRTY=" ${red}✗"
 SCM_THEME_PROMPT_CLEAN=" ${bold_green}✓"
 SCM_THEME_PROMPT_PREFIX=" |"

themes/binaryanomaly/binaryanomaly.theme.bash

@@ -1,9 +1,8 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
-
 
 # Detect whether a reboot is required
 function show_reboot_required() {
-  if [ ! -z "$_bf_prompt_reboot_info" ]; then
+	if [ -n "$_bf_prompt_reboot_info" ]; then
 		if [ -f /var/run/reboot-required ]; then
 			printf "Reboot required!"
 		fi
@@ -13,10 +12,10 @@ function show_reboot_required() {
 # Set different host color for local and remote sessions
 function set_host_color() {
 	# Detect if connection is through SSH
-  if [[ ! -z $SSH_CLIENT ]]; then
+	if [[ -n $SSH_CLIENT ]]; then
-    printf "${lime_yellow}"
+		printf '%s' "${lime_yellow}"
 	else
-    printf "${light_orange}"
+		printf '%s' "${light_orange}"
 	fi
 }
 
@@ -24,18 +23,17 @@ function set_host_color() {
 function set_user_color() {
 	case $(id -u) in
 		0)
-      printf "${red}"
+			printf '%s' "${red}"
 			;;
 		*)
-      printf "${cyan}"
+			printf '%s' "${cyan}"
 			;;
 	esac
 }
 
 scm_prompt() {
 	CHAR=$(scm_char)
-  if [ $CHAR = $SCM_NONE_CHAR ]
+	if [ "$CHAR" = "$SCM_NONE_CHAR" ]; then
-    then
 		return
 	else
 		echo "[$(scm_char)$(scm_prompt_info)]"
@@ -57,7 +55,7 @@ function set_custom_colors() {
 }
 
 __ps_time() {
-  echo "$(clock_prompt)${normal}\n"
+	printf '%s' "$(clock_prompt)${normal}\n"
 }
 
 function prompt_command() {

themes/bira/bira.theme.bash

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
 
 SCM_THEME_PROMPT_PREFIX=" ${yellow}‹"
 SCM_THEME_PROMPT_SUFFIX="›${reset_color}"

themes/bobby-python/bobby-python.theme.bash

@@ -1,4 +1,5 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
+
 SCM_THEME_PROMPT_DIRTY=" ${red}✗"
 SCM_THEME_PROMPT_CLEAN=" ${bold_green}✓"
 SCM_THEME_PROMPT_PREFIX=" |"

themes/bobby/bobby.theme.bash

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
 
 SCM_THEME_PROMPT_DIRTY=" ${red}✗"
 SCM_THEME_PROMPT_CLEAN=" ${bold_green}✓"
@@ -14,10 +14,10 @@ RVM_THEME_PROMPT_PREFIX="|"
 RVM_THEME_PROMPT_SUFFIX="|"
 
 __bobby_clock() {
-  printf "$(clock_prompt) "
+	printf '%s' "$(clock_prompt) "
 
 	if [ "${THEME_SHOW_CLOCK_CHAR}" == "true" ]; then
-    printf "$(clock_char) "
+		printf '%s' "$(clock_char) "
 	fi
 }
 

themes/brainy/brainy.theme.bash

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
 
 # Brainy Bash Prompt for Bash-it
 # by MunifTanjim
@@ -10,7 +10,7 @@
 ____brainy_top_left_parse() {
 	ifs_old="${IFS}"
 	IFS="|"
-	args=( $1 )
+	read -r -a args <<< "$@"
 	IFS="${ifs_old}"
 	if [ -n "${args[3]}" ]; then
 		_TOP_LEFT+="${args[2]}${args[3]}"
@@ -25,7 +25,7 @@ ____brainy_top_left_parse() {
 ____brainy_top_right_parse() {
 	ifs_old="${IFS}"
 	IFS="|"
-	args=( $1 )
+	read -r -a args <<< "$@"
 	IFS="${ifs_old}"
 	_TOP_RIGHT+=" "
 	if [ -n "${args[3]}" ]; then
@@ -42,7 +42,7 @@ ____brainy_top_right_parse() {
 ____brainy_bottom_parse() {
 	ifs_old="${IFS}"
 	IFS="|"
-	args=( $1 )
+	read -r -a args <<< "$@"
 	IFS="${ifs_old}"
 	_BOTTOM+="${args[0]}${args[1]}"
 	[ ${#args[1]} -gt 0 ] && _BOTTOM+=" "
@@ -135,11 +135,11 @@ ___brainy_prompt_ruby() {
 }
 
 ___brainy_prompt_todo() {
-	[ "${THEME_SHOW_TODO}" != "true" ] ||
+	[ "${THEME_SHOW_TODO}" != "true" ] \
-	[ -z "$(which todo.sh)" ] && return
+		|| [ -z "$(which todo.sh)" ] && return
 	color=$bold_white
 	box="[|]"
-	info="t:$(todo.sh ls | egrep "TODO: [0-9]+ of ([0-9]+)" | awk '{ print $4 }' )"
+	info="t:$(todo.sh ls | grep -E "TODO: [0-9]+ of ([0-9]+)" | awk '{ print $4 }')"
 	printf "%s|%s|%s|%s" "${color}" "${info}" "${bold_green}" "${box}"
 }
 
@@ -152,9 +152,9 @@ ___brainy_prompt_clock() {
 }
 
 ___brainy_prompt_battery() {
-	! _command_exists battery_percentage ||
+	! _command_exists battery_percentage \
-	[ "${THEME_SHOW_BATTERY}" != "true" ] ||
+		|| [ "${THEME_SHOW_BATTERY}" != "true" ] \
-	[ "$(battery_percentage)" = "no" ] && return
+		|| [ "$(battery_percentage)" = "no" ] && return
 
 	info=$(battery_percentage)
 	color=$bold_green
@@ -190,13 +190,13 @@ ___brainy_prompt_char() {
 __brainy_show() {
 	typeset _seg=${1:-}
 	shift
-	export THEME_SHOW_${_seg}=true
+	export "THEME_SHOW_${_seg}"=true
 }
 
 __brainy_hide() {
 	typeset _seg=${1:-}
 	shift
-	export THEME_SHOW_${_seg}=false
+	export "THEME_SHOW_${_seg}"=false
 }
 
 _brainy_completion() {
@@ -207,16 +207,14 @@ _brainy_completion() {
 	actions="show hide"
 	segments="battery clock exitcode python ruby scm sudo todo"
 	case "${_action}" in
-		show)
+		show | hide)
-			COMPREPLY=( $(compgen -W "${segments}" -- "${cur}") )
+			# shellcheck disable=SC2207
-			return 0
-			;;
-		hide)
 			COMPREPLY=($(compgen -W "${segments}" -- "${cur}"))
 			return 0
 			;;
 	esac
 
+	# shellcheck disable=SC2207
 	COMPREPLY=($(compgen -W "${actions}" -- "${cur}"))
 	return 0
 }
@@ -228,9 +226,11 @@ brainy() {
 	typeset func
 	case $action in
 		show)
-			func=__brainy_show;;
+			func=__brainy_show
+			;;
 		hide)
-			func=__brainy_hide;;
+			func=__brainy_hide
+			;;
 	esac
 	for seg in ${segs}; do
 		seg=$(printf "%s" "${seg}" | tr '[:lower:]' '[:upper:]')

themes/brunton/brunton.theme.bash

@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+# shellcheck shell=bash
 
 SCM_THEME_PROMPT_PREFIX=""
 SCM_THEME_PROMPT_SUFFIX=""
@@ -10,16 +10,14 @@ SCM_SVN_CHAR="${bold_cyan}⑆${normal}"
 SCM_HG_CHAR="${bold_red}☿${normal}"
 
 is_vim_shell() {
-	if [ ! -z "$VIMRUNTIME" ]
+	if [ -n "$VIMRUNTIME" ]; then
-	then
 		echo "[${cyan}vim shell${normal}]"
 	fi
 }
 
 scm_prompt() {
 	CHAR=$(scm_char)
-	if [ $CHAR = $SCM_NONE_CHAR ]
+	if [ "$CHAR" = "$SCM_NONE_CHAR" ]; then
-	then
 		return
 	else
 		echo " $(scm_char) (${white}$(scm_prompt_info)${normal})"