From 497f1a952016a38f8e61c5a8b175fa8fc2bef148 Mon Sep 17 00:00:00 2001 From: Nils Winkler Date: Thu, 19 May 2016 09:03:01 +0200 Subject: [PATCH 1/3] Fixed indentation It was using a mixture of tabs and spaces. Converted to 2 spaces. --- plugins/available/killrails.plugin.bash | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/available/killrails.plugin.bash b/plugins/available/killrails.plugin.bash index 21983f82..10a62164 100644 --- a/plugins/available/killrails.plugin.bash +++ b/plugins/available/killrails.plugin.bash @@ -1,4 +1,4 @@ -cite about-plugin +cite about-plugin about-plugin 'Function to kill a daemonized Rails server.' # Quick function to kill a daemonized Rails server @@ -9,10 +9,10 @@ function killrails() { railsPid="$(cat tmp/pids/server.pid)" if [ ! -z "$railsPid" ]; then echo "[OK] Rails Server Process Id : ${railsPid}" - kill -9 $railsPid - echo "[OK] Process Killed" + kill -9 $railsPid + echo "[OK] Process Killed" else - echo "[FAIL] Error killing Rails server" - return 1 + echo "[FAIL] Error killing Rails server" + return 1 fi } From d32316bdf9b58c33e7132f36f191fa6c753786e4 Mon Sep 17 00:00:00 2001 From: Nils Winkler Date: Thu, 19 May 2016 09:03:59 +0200 Subject: [PATCH 2/3] Fixed group meta tag --- plugins/available/killrails.plugin.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/available/killrails.plugin.bash b/plugins/available/killrails.plugin.bash index 10a62164..c5b2bbe6 100644 --- a/plugins/available/killrails.plugin.bash +++ b/plugins/available/killrails.plugin.bash @@ -4,7 +4,7 @@ about-plugin 'Function to kill a daemonized Rails server.' # Quick function to kill a daemonized Rails server function killrails() { about 'Searches for a daemonized Rails server in tmp/pids and attempts to kill it.' - group 'server' + group 'killrails' railsPid="$(cat tmp/pids/server.pid)" if [ ! -z "$railsPid" ]; then From 2618d2141fa75a36e79bf3628dc35e5023e50465 Mon Sep 17 00:00:00 2001 From: Nils Winkler Date: Thu, 19 May 2016 09:09:37 +0200 Subject: [PATCH 3/3] Fixed unit tests --- test/lib/search.bats | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/lib/search.bats b/test/lib/search.bats index dc4ba59a..0871e3a2 100644 --- a/test/lib/search.bats +++ b/test/lib/search.bats @@ -23,7 +23,7 @@ NO_COLOR=true run _bash-it-search 'ruby' 'gem' 'bundle' 'rake' 'rails' # And verify [[ "${lines[0]/✓/}" == ' aliases => bundler rails' ]] && \ - [[ "${lines[1]/✓/}" == ' plugins => chruby chruby-auto ruby' ]] && \ + [[ "${lines[1]/✓/}" == ' plugins => chruby chruby-auto killrails ruby' ]] && \ [[ "${lines[2]/✓/}" == ' completions => bundler gem rake' ]] } @@ -31,7 +31,7 @@ NO_COLOR=true run _bash-it-search 'ruby' 'gem' 'bundle' 'rake' 'rails' '--disable' run _bash-it-search 'ruby' 'gem' 'bundle' '-chruby' 'rake' 'rails' [[ "${lines[0]/✓/}" == ' aliases => bundler rails' ]] && \ - [[ "${lines[1]/✓/}" == ' plugins => ruby' ]] && \ + [[ "${lines[1]/✓/}" == ' plugins => killrails ruby' ]] && \ [[ "${lines[2]/✓/}" == ' completions => bundler gem rake' ]] } @@ -40,7 +40,7 @@ NO_COLOR=true run _enable-alias 'rails' run _bash-it-search 'ruby' 'gem' 'bundle' 'rake' 'rails' [[ "${lines[0]}" == ' aliases => bundler ✓rails' ]] && \ - [[ "${lines[1]}" == ' plugins => chruby chruby-auto ruby' ]] && \ + [[ "${lines[1]}" == ' plugins => chruby chruby-auto killrails ruby' ]] && \ [[ "${lines[2]}" == ' completions => bundler gem rake' ]] } @@ -48,6 +48,6 @@ NO_COLOR=true run _bash-it-search 'ruby' 'gem' 'bundle' 'rake' '-chruby' 'rails' '--enable' run _bash-it-search 'ruby' 'gem' 'bundle' 'rake' '-chruby' 'rails' [[ "${lines[0]}" == ' aliases => ✓bundler ✓rails' ]] && \ - [[ "${lines[1]}" == ' plugins => ✓ruby' ]] && \ + [[ "${lines[1]}" == ' plugins => ✓killrails ✓ruby' ]] && \ [[ "${lines[2]}" == ' completions => ✓bundler ✓gem ✓rake' ]] }