XorA
/
bash-it
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1627 from NoahGorny/fix-alias-completion-plugin 

plugins: Fix quotes around prec_word agruments
pull/1644/head
Nils Winkler 2020-07-15 08:54:56 +02:00 committed by GitHub
parent f8d1a1c2d7 0053f27820
commit 43ef48544d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/available/alias-completion.plugin.bash
View File

@ -71,7 +71,7 @@ function alias_completion {
# with the last word in the unaliased form, i.e., # with the last word in the unaliased form, i.e.,
# alias_cmd + ' ' + alias_args. # alias_cmd + ' ' + alias_args.
if [[ \$COMP_LINE == \"\$prec_word \$compl_word\" ]]; then if [[ \$COMP_LINE == \"\$prec_word \$compl_word\" ]]; then
prec_word=\"$alias_cmd $alias_args\" prec_word='$alias_cmd $alias_args'
prec_word=\${prec_word#* } prec_word=\${prec_word#* }
fi fi
(( COMP_CWORD += ${#alias_arg_words[@]} )) (( COMP_CWORD += ${#alias_arg_words[@]} ))

19
test/plugins/alias-completion.plugin.bats 100644
View File

@ -0,0 +1,19 @@
#!/usr/bin/env bats
load ../test_helper
load ../../lib/composure
load ../../completion/available/git.completion
@test "alias-completion: See that aliases with double quotes and brackets do not break the plugin" {
alias gtest="git log --graph --pretty=format:'%C(bold)%h%Creset%C(magenta)%d%Creset %s %C(yellow)<%an> %C(cyan)(%cr)%Creset' --abbrev-commit --date=relative"
load ../../plugins/available/alias-completion.plugin
assert_success
}
@test "alias-completion: See that aliases with single quotes and brackets do not break the plugin" {
alias gtest='git log --graph --pretty=format:"%C(bold)%h%Creset%C(magenta)%d%Creset %s %C(yellow)<%an> %C(cyan)(%cr)%Creset" --abbrev-commit --date=relative'
load ../../plugins/available/alias-completion.plugin
assert_success
}