From 079652e6e737e5face09fc6dcb1851ee001586e7 Mon Sep 17 00:00:00 2001
From: John D Pell <John+git@gaelicWizard.net>
Date: Sat, 8 Jan 2022 08:44:05 -0800
Subject: [PATCH] plugin/nginx: cleanup

Dont overwrite user-set variable, and quote path. Local some variables, `shellcheck`, `shfmt`
---
 clean_files.txt                     |  1 +
 plugins/available/nginx.plugin.bash | 85 +++++++++++++----------------
 2 files changed, 38 insertions(+), 48 deletions(-)

diff --git a/clean_files.txt b/clean_files.txt
index 4ecda787..0abad60b 100644
--- a/clean_files.txt
+++ b/clean_files.txt
@@ -104,6 +104,7 @@ plugins/available/jekyll.plugin.bash
 plugins/available/jump.plugin.bash
 plugins/available/less-pretty-cat.plugin.bash
 plugins/available/man.plugin.bash
+plugins/available/nginx.plugin.bash
 plugins/available/node.plugin.bash
 plugins/available/nodenv.plugin.bash
 plugins/available/osx-timemachine.plugin.bash
diff --git a/plugins/available/nginx.plugin.bash b/plugins/available/nginx.plugin.bash
index c540a23a..8d75a881 100644
--- a/plugins/available/nginx.plugin.bash
+++ b/plugins/available/nginx.plugin.bash
@@ -1,66 +1,55 @@
-cite about-plugin
+# shellcheck shell=bash
 about-plugin 'manage your nginx service'
 
-export NGINX_PATH='/opt/nginx'
-pathmunge $NGINX_PATH/sbin after
+pathmunge "${NGINX_PATH:=/opt/nginx}/sbin" after
+export NGINX_PATH
 
 function nginx_reload() {
-  about 'reload your nginx config'
-  group 'nginx'
+	about 'reload your nginx config'
+	group 'nginx'
 
-  FILE="${NGINX_PATH}/logs/nginx.pid"
-  if [ -e $FILE ]; then
-    echo "Reloading NGINX..."
-    PID=`cat $NGINX_PATH/logs/nginx.pid`
-    sudo kill -HUP $PID
-  else
-    echo "Nginx pid file not found"
-    return 0
-  fi
+	local FILE="${NGINX_PATH?}/logs/nginx.pid"
+	if [[ -s $FILE ]]; then
+		echo "Reloading NGINX..."
+		read -r PID < "${FILE}"
+		sudo kill -HUP "${PID?}"
+	else
+		echo "Nginx pid file not found"
+		return 0
+	fi
 }
 
 function nginx_stop() {
-  about 'stop nginx'
-  group 'nginx'
+	about 'stop nginx'
+	group 'nginx'
 
-  FILE="${NGINX_PATH}/logs/nginx.pid"
-  if [ -e $FILE ]; then
-    echo "Stopping NGINX..."
-    PID=`cat $NGINX_PATH/logs/nginx.pid`
-    sudo kill -INT $PID
-  else
-    echo "Nginx pid file not found"
-    return 0
-  fi
+	local FILE="${NGINX_PATH?}/logs/nginx.pid"
+	if [[ -s $FILE ]]; then
+		echo "Stopping NGINX..."
+		read -r PID < "${FILE}"
+		sudo kill -INT "${PID?}"
+	else
+		echo "Nginx pid file not found"
+		return 0
+	fi
 }
 
 function nginx_start() {
-  about 'start nginx'
-  group 'nginx'
+	about 'start nginx'
+	group 'nginx'
 
-  FILE="${NGINX_PATH}/sbin/nginx"
-  if [ -e $FILE ]; then
-    echo "Starting NGINX..."
-    sudo $NGINX_PATH/sbin/nginx
-  else
-    echo "Couldn't start nginx"
-  fi
+	local FILE="${NGINX_PATH?}/sbin/nginx"
+	if [[ -x $FILE ]]; then
+		echo "Starting NGINX..."
+		sudo "${FILE}"
+	else
+		echo "Couldn't start nginx"
+	fi
 }
 
 function nginx_restart() {
-  about 'restart nginx'
-  group 'nginx'
+	about 'restart nginx'
+	group 'nginx'
 
-  FILE="${NGINX_PATH}/logs/nginx.pid"
-  if [ -e $FILE ]; then
-    echo "Stopping NGINX..."
-    PID=`cat $NGINX_PATH/logs/nginx.pid`
-    sudo kill -INT $PID
-    sleep 1
-    echo "Starting NGINX..."
-    sudo $NGINX_PATH/sbin/nginx
-  else
-    echo "Nginx pid file not found"
-    return 0
-  fi
+	nginx_stop && nginx_start
 }